Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

ci: add PAT so that tag generated from CI will trigger the docker images #57

Merged
merged 1 commit into from
Jan 12, 2024
Merged

ci: add PAT so that tag generated from CI will trigger the docker images #57

merged 1 commit into from
Jan 12, 2024
+2 −4

Conversation

MSevey
Copy link
Contributor

@MSevey MSevey commented Jan 12, 2024 •
edited by coderabbitai bot
Loading

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Chores
    • Updated the release workflow trigger conditions for improved deployment process.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2024 •
edited
Loading

Walkthrough

The GitHub Actions workflow for releases has been updated to be manually triggered, removing the automatic execution upon tag creation. Additionally, the token used for Docker-related actions within the release process has been changed to a different Personal Access Token.

Changes

File Change Summary
.github/workflows/ci_release.yml Modified to trigger release job only on manual dispatch; updated secret token for Docker.

🐇🎉
To trigger a release, now just a click,
No more tags pushing, that old automatic trick.
With a new secret in place, all sleek,
Let's hop to the workflow, as we speak.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Jan 12, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 401f8a9 and 8e647f2.
Files selected for processing (1)
  • .github/workflows/ci_release.yml (1 hunks)
Additional comments: 3
.github/workflows/ci_release.yml (3)

  • 40-40: The conditional trigger for the release job has been correctly updated to only execute on a workflow_dispatch event. This aligns with the PR objectives to require manual intervention for releases.

  • 47-47: The github-token has been replaced with PAT_FOR_DOCKER_TRIGGER. Ensure that this Personal Access Token has been configured with the correct permissions in the repository's secrets to trigger Docker image creation.

  • 37-48: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [7-8]

The logic for triggering the release job on tag pushes (tags: - "v*") appears to have been removed, as mentioned in the summary. This change should be carefully considered as it alters the automation of the release process, requiring manual dispatch for new releases.

@MSevey MSevey requested review from tuxcanfly and removed request for sysrex, Bidon15 and smuu January 12, 2024 20:44
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (401f8a9) 74.05% compared to head (8e647f2) 74.05%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   74.05%   74.05%           
=======================================
  Files           2        2           
  Lines         158      158           
=======================================
  Hits          117      117           
  Misses         28       28           
  Partials       13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MSevey MSevey merged commit bdb5913 into main Jan 12, 2024
26 of 27 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@tuxcanfly tuxcanfly tuxcanfly approved these changes

Assignees

@MSevey MSevey

Labels
None yet
Projects
Rollkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSevey @tuxcanfly